security: fix vulnerabilities and harden code (2026-03-12)

Path traversal fixes:
- DeleteFile.js: use path.resolve() + symlink protection (CRITICAL)
- DeleteFileFolder.js: add path.resolve() validation + symlink check (CRITICAL)
- RenameFile.js: use path.resolve() with proper prefix check + symlink guard (HIGH)
- attachments.js: add baseDir validation + skip symlinks in recursive search (MEDIUM)

XSS fixes:
- dashboard.js: escape user input in onerror/onclick inline attributes (HIGH)
- paramadminsettingsetup.script.js: escape values in innerHTML template (MEDIUM)

Input validation:
- inputValidationMiddleware.js: block suspicious requests instead of logging only (MEDIUM)

Version bump: 1.2.2-beta → 1.2.3-beta

Middlewares/inputValidationMiddleware.js

@@ -171,7 +171,8 @@ const inputValidationMiddleware = (req, res, next) => {
         if (req.body && typeof req.body === 'object') {
             const bodyStr = JSON.stringify(req.body);
             if (suspiciousPatterns.some(pattern => pattern.test(bodyStr))) {
-                logger.warn(`Suspicious input detected in request body from ${req.ip}: ${req.path}`);
+                logger.warn(`Suspicious input blocked in request body from ${req.ip}: ${req.path}`);
+                return res.status(400).json({ error: 'Input invalide détecté.' });
             }
         }
 
@@ -179,11 +180,11 @@ const inputValidationMiddleware = (req, res, next) => {
         if (req.query && typeof req.query === 'object') {
             const queryStr = JSON.stringify(req.query);
             if (suspiciousPatterns.some(pattern => pattern.test(queryStr))) {
-                logger.warn(`Suspicious input detected in query params from ${req.ip}: ${req.path}`);
+                logger.warn(`Suspicious input blocked in query params from ${req.ip}: ${req.path}`);
+                return res.status(400).json({ error: 'Input invalide détecté.' });
             }
         }
 
-        // Continuer sans bloquer (logging only pour ne pas casser l'app)
         next();
     } catch (error) {
         logger.error('Error in input validation middleware:', error);

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cdn-app/insider-myaxrin-labs-dinawo",
-  "version": "1.2.2-beta",
+  "version": "1.2.3-beta",
   "description": "",
   "main": "server.js",
   "scripts": {

public/js/dashboard.js

@@ -1,4 +1,10 @@
 // Dashboard JavaScript - Version corrigée
+
+function escapeAttr(str) {
+    if (typeof str !== 'string') return '';
+    return str.replace(/&/g, '&amp;').replace(/'/g, '&#39;').replace(/"/g, '&quot;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
+}
+
 document.addEventListener('DOMContentLoaded', function() {
     // Initialisation générale
     initializeDashboard();
@@ -682,10 +688,10 @@ function createCollaborationModal(itemName, itemType, data) {
                                 ? data.activeUsers.map(user => `
                                     <div class="collaboration-user-item">
                                         <div class="user-avatar-wrapper">
-                                            <img src="${user.profilePicture || getDefaultAvatar(user.name)}" 
+                                            <img src="${user.profilePicture || getDefaultAvatar(user.name)}"
-                                                 alt="${user.name}" 
+                                                 alt="${escapeAttr(user.name)}"
                                                  class="user-avatar"
-                                                 onerror="this.src='${getDefaultAvatar(user.name)}'">
+                                                 onerror="this.src='${escapeAttr(getDefaultAvatar(user.name))}'">
                                             <div class="user-status-indicator"></div>
                                         </div>
                                         <div class="user-details">
@@ -696,8 +702,8 @@ function createCollaborationModal(itemName, itemType, data) {
                                             </div>
                                         </div>
                                         <div class="user-actions">
-                                            <button class="action-btn remove-btn" 
+                                            <button class="action-btn remove-btn"
-                                                    onclick="removeCollaborator('${itemName}', '${itemType}', '${user.id}')"
+                                                    onclick="removeCollaborator('${escapeAttr(itemName)}', '${escapeAttr(itemType)}', '${escapeAttr(user.id)}')"
                                                     title="Retirer ce collaborateur">
                                                 <i class="fas fa-user-minus"></i>
                                             </button>
@@ -794,10 +800,10 @@ function searchCollabUser(username, itemName, itemType, modal) {
                     <div class="search-result-item">
                         <div class="result-user-info">
                             <div class="result-avatar-wrapper">
-                                <img src="${result.user.profilePicture || getDefaultAvatar(result.user.name)}" 
+                                <img src="${result.user.profilePicture || getDefaultAvatar(result.user.name)}"
-                                     alt="${result.user.name}"
+                                     alt="${escapeAttr(result.user.name)}"
                                      class="result-avatar"
-                                     onerror="this.src='${getDefaultAvatar(result.user.name)}'">
+                                     onerror="this.src='${escapeAttr(getDefaultAvatar(result.user.name))}'">
                             </div>
                             <div class="result-details">
                                 <div class="result-name">${result.user.name}</div>
@@ -807,8 +813,8 @@ function searchCollabUser(username, itemName, itemType, modal) {
                                 </div>
                             </div>
                         </div>
-                        <button class="btn btn-primary add-user-btn" 
+                        <button class="btn btn-primary add-user-btn"
-                                onclick="addCollaborator('${itemName}', '${itemType}', '${result.user.id}')"
+                                onclick="addCollaborator('${escapeAttr(itemName)}', '${escapeAttr(itemType)}', '${escapeAttr(result.user.id)}')"
                                 title="Ajouter ce collaborateur">
                             <i class="fas fa-user-plus"></i>
                             <span>Ajouter</span>

public/js/paramadminsettingsetup.script.js

@@ -1,3 +1,8 @@
+function escapeAttr(str) {
+    if (typeof str !== 'string') return '';
+    return str.replace(/&/g, '&amp;').replace(/'/g, '&#39;').replace(/"/g, '&quot;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
+}
+
 const body = document.body;
 const themeSwitcher = document.getElementById('themeSwitcher');
 
@@ -319,11 +324,11 @@ function addPath(type) {
     const div = document.createElement('div');
     div.className = 'flex items-center space-x-2 py-2 px-3 bg-gray-800 rounded-lg animate';
     div.innerHTML = `
-        <span class="flex-1">${value}</span>
+        <span class="flex-1">${escapeAttr(value)}</span>
         <button type="button" onclick="removePath(this)" class="text-gray-400 hover:text-red-500">
             <i class="fas fa-times"></i>
         </button>
-        <input type="hidden" name="logs[${type === 'exclude' ? 'excludePaths' : 'includeOnly'}][]" value="${value}">
+        <input type="hidden" name="logs[${type === 'exclude' ? 'excludePaths' : 'includeOnly'}][]" value="${escapeAttr(value)}">
     `;
     list.appendChild(div);
     input.value = '';

routes/Dpanel/API/DeleteFile.js

@@ -156,19 +156,30 @@ router.post('/', authenticateToken, (req, res) => {
         return res.status(400).json({ message: 'User ID or filename missing for file deletion.' });
     }
 
-    const userFolderPath = path.join('cdn-files', userId);
+    const userFolderPath = path.resolve('cdn-files', userId);
 
     function findAndDeleteFile(folderPath) {
+        const resolvedFolder = path.resolve(folderPath);
+        if (!resolvedFolder.startsWith(userFolderPath + path.sep) && resolvedFolder !== userFolderPath) {
+            return false;
+        }
+
         const filesInFolder = fs.readdirSync(folderPath);
 
         for (const file of filesInFolder) {
             const filePath = path.join(folderPath, file);
+            const resolvedFilePath = path.resolve(filePath);
 
-            if (!filePath.startsWith(userFolderPath)) {
+            if (!resolvedFilePath.startsWith(userFolderPath + path.sep)) {
                 return false;
             }
 
-            if (fs.statSync(filePath).isDirectory()) {
+            const stat = fs.lstatSync(filePath);
+            if (stat.isSymbolicLink()) {
+                continue;
+            }
+
+            if (stat.isDirectory()) {
                 const fileDeletedInSubfolder = findAndDeleteFile(filePath);
                 if (fileDeletedInSubfolder) {
                     return true;

routes/Dpanel/API/DeleteFileFolder.js

@@ -26,8 +26,25 @@ router.post('/:folderName', authMiddleware, (req, res) => {
     const userId = req.userData.name;
     const { filename } = req.body;
 
-    const userFolderPath = path.join('cdn-files', userId || '');
+    if (!userId || !filename) {
-const filePath = path.join(userFolderPath, req.params.folderName, filename || '');
+        return res.status(400).json({ error: 'Paramètres manquants.' });
+    }
+
+    const userFolderPath = path.resolve('cdn-files', userId);
+    const filePath = path.resolve(userFolderPath, req.params.folderName, filename);
+
+    if (!filePath.startsWith(userFolderPath + path.sep)) {
+        return res.status(403).json({ error: 'Accès non autorisé.' });
+    }
+
+    try {
+        const stat = fs.lstatSync(filePath);
+        if (stat.isSymbolicLink()) {
+            return res.status(403).json({ error: 'Accès non autorisé.' });
+        }
+    } catch (e) {
+        return res.status(404).json({ error: 'Le fichier spécifié n\'existe pas.' });
+    }
 
     if (!fs.existsSync(filePath)) {
         return res.status(404).json({ error: 'Le fichier spécifié n\'existe pas.' });

routes/Dpanel/API/RenameFile.js

@@ -142,16 +142,21 @@ router.post('/', authMiddleware, async (req, res) => {
       return res.status(400).json('Both currentName and newName must be provided.');
   }
 
-  const userDir = path.join('cdn-files', userId);
+  const userDir = path.resolve('cdn-files', userId);
-  const currentPath = path.join(userDir, filePath, currentName);
+  const currentPath = path.resolve(userDir, filePath, currentName);
-  const newPath = path.join(userDir, filePath, newName);
+  const newPath = path.resolve(userDir, filePath, newName);
 
-  if (!currentPath.startsWith(userDir) || !newPath.startsWith(userDir)) {
+  if (!currentPath.startsWith(userDir + path.sep) || !newPath.startsWith(userDir + path.sep)) {
       ErrorLogger.error('Unauthorized directory access attempt');
       return res.status(403).json('Unauthorized directory access attempt');
   }
 
   try {
+      const stat = await fs.promises.lstat(currentPath);
+      if (stat.isSymbolicLink()) {
+          return res.status(403).json('Unauthorized: symbolic links are not allowed');
+      }
+
       await fs.promises.rename(currentPath, newPath);
 
       const data = await fs.promises.readFile(path.join(__dirname, '../../../data', 'file_info.json'), 'utf8');
@@ -170,7 +175,7 @@ router.post('/', authMiddleware, async (req, res) => {
           await fs.promises.writeFile(path.join(__dirname, '../../../data', 'file_info.json'), JSON.stringify(fileInfo, null, 2), 'utf8');
       }
 
-      res.status(200).json('Operation was successful.');  
+      res.status(200).json('Operation was successful.');
   } catch (err) {
       console.error(err);
       return res.status(500).json('Error renaming the file.');
@@ -186,16 +191,21 @@ router.post('/:filePath*', authMiddleware, async (req, res) => {
         return res.status(400).json('Both currentName and newName must be provided.');
     }
 
-    const userDir = path.join('cdn-files', userId);
+    const userDir = path.resolve('cdn-files', userId);
-    const currentPath = path.join(userDir, filePath, currentName);
+    const currentPath = path.resolve(userDir, filePath, currentName);
-    const newPath = path.join(userDir, filePath, newName);
+    const newPath = path.resolve(userDir, filePath, newName);
 
-    if (!currentPath.startsWith(userDir) || !newPath.startsWith(userDir)) {
+    if (!currentPath.startsWith(userDir + path.sep) || !newPath.startsWith(userDir + path.sep)) {
         ErrorLogger.error('Unauthorized directory access attempt');
         return res.status(403).json('Unauthorized directory access attempt');
     }
 
     try {
+        const stat = await fs.promises.lstat(currentPath);
+        if (stat.isSymbolicLink()) {
+            return res.status(403).json('Unauthorized: symbolic links are not allowed');
+        }
+
         await fs.promises.rename(currentPath, newPath);
 
         const data = await fs.promises.readFile(path.join(__dirname, '../../../data', 'file_info.json'), 'utf8');
@@ -214,7 +224,7 @@ router.post('/:filePath*', authMiddleware, async (req, res) => {
             await fs.promises.writeFile(path.join(__dirname, '../../../data', 'file_info.json'), JSON.stringify(fileInfo, null, 2), 'utf8');
         }
 
-        res.status(200).json('Operation was successful.');  
+        res.status(200).json('Operation was successful.');
     } catch (err) {
         console.error(err);
         return res.status(500).json('Error renaming the file.');

routes/attachments.js

@@ -30,21 +30,37 @@ async function findFileInUserDir(userId, filename) {
     return findFileInDir(userDir, filename);
 }
 
-async function findFileInDir(dir, filename) {
+async function findFileInDir(dir, filename, baseDir) {
+    if (!baseDir) baseDir = dir;
+    const resolvedDir = path.resolve(dir);
+    const resolvedBase = path.resolve(baseDir);
+
+    if (resolvedDir !== resolvedBase && !resolvedDir.startsWith(resolvedBase + path.sep)) {
+        return null;
+    }
+
     let files;
     try {
         files = await fs.readdir(dir, { withFileTypes: true });
     } catch (err) {
-        return null; // Directory does not exist
+        return null;
     }
 
     for (const file of files) {
         const filePath = path.join(dir, file.name);
 
+        if (file.isSymbolicLink()) {
+            continue;
+        }
+
         if (file.name === filename && file.isFile()) {
-            return filePath;
+            const resolvedFile = path.resolve(filePath);
+            if (resolvedFile.startsWith(resolvedBase + path.sep)) {
+                return filePath;
+            }
+            return null;
         } else if (file.isDirectory()) {
-            const found = await findFileInDir(filePath, filename);
+            const found = await findFileInDir(filePath, filename, baseDir);
             if (found) {
                 return found;
             }